Bạch Vân Thành

I worked with Kohana for awhile. Sprig is my choose for ORM. It’s really good but its development dropped. As I can see on GitHub, it mostly everybody has their own fork for Sprig. Sprig has a branch call feature/kohana3.1 which is compatible with Kohana3.x validation model. It also has some code which added back filter and callback but it doesn’t work at all because of wrong implement.

Since we should not change core code of Sprig, it will be better to extends Sprig_Core class. Create a new file application/clases/sprig.php and override method check().

<?php
public function check(array $data = NULL) {
        if ($data === NULL) {
            // Use the current data set
            $data = $this->changed();
        }

        $data = Validation::factory($data);
        $alter_data = array();
        foreach ($this->_fields as $name => $field) {
            if (!$data->offsetExists($name)) {
                // Do not add any rules for this field
                continue;
            }
            $data->label($name, $field->label);

            if ($field->filters) {
                foreach ($field->filters as $filter => $whoknows) {
                    if (is_callable($filter)) {
                        $alter_data[$name] = call_user_func($filter, $data[$name]);
                    } elseif (is_callable($whoknows)) {
                        $alter_data[$name] = call_user_func($whoknows, $data[$name]);
                    } else {
                        throw new Kohana_Exception('Filter is Invalid');
                    }
                }
            }

            if ($field->rules) {
                foreach ($field->rules as $rule => $rule_data) {
                    if ($rule_data[0]) { // if the rule has parameters
                        $data->rule($name, $rule, $rule_data);
                    } else {
                        $data->rule($name, $rule);
                    }
                }
            }

            if ($field->callbacks) {
                foreach ($field->callbacks as $callback) {
                    $data->rule($name, $callback, array(':validation', ':field'));
                }
            }
        }

        if (!$data->check()) {
            throw new Validation_Exception($data);
        }

        return Arr::overwrite($data->as_array(), $alter_data);
    }

Also, timestamp field has some wrong implement since it convert date/time to UNIX timestamp instead of correct timestamp data of mysql. Becauseof that, Timestamp field of Sprig extends Sprig_Field_Integer. Correct implement should be:

<?php
class Sprig_Field_Timestamp extends Sprig_Field_Char {

    public $auto_now_create = FALSE;
    public $auto_now_update = FALSE;
    public $default = NULL;
    public $format = 'Y-m-d G:i:s';
    public $mysql_time = TRUE; //Use mysql timestamp or timestamp of PHP

    public function value($value) {
        if (TRUE === $this->mysql_time) {
            if (is_integer($value)) {
                return date($this->format, $value);
            }
            return parent::value($value);
        }

        if ($value AND is_string($value) AND !ctype_digit($value)) {
            $value = strtotime($value);
        }

        return parent::value($value);
    }

    public function verbose($value) {
        if (is_integer($value)) {
            return date($this->format, $value);
        } else {
            return $value;
        }
    }

}

For Hasmany field, it should return an array of data.

Original implement:

<?php
	public function value($value)
	{
		if (empty($value) AND $this->empty)
		{
			return array();
		}
		elseif (is_object($value))
		{
			$model = Sprig::factory($this->model);

			// Assume this is a Database_Result objecta
			$value = $value->as_array(NULL, $model->pk());
		}
		else
		{
			// Value must always be an array
			$value = (array) $value;
		}

		if ($value)
		{
			// Combine the value to make a mirrored array
			$value = array_combine($value, $value);

			foreach ($value as $id)
			{
				// Convert the value to the proper type
				$value[$id] = parent::value($id);
			}
		}

		return $value;
	}

Correct implement:

    public function value($value) {
        if (empty($value) AND $this->empty) {
            return array();
        } elseif (is_object($value)) {
            $model = Sprig::factory($this->model);

            // Assume this is a Database_Result object
            $pk = $model->pk();
            if (is_string($pk)) {
                $value = $value->as_array(NULL, $pk);
            } else {
                $numOfRecord = $value->count();
                $rows = array();
                foreach ($pk as $col) {
                    $rows[$col] = $value->as_array(NULL, $col);
                }
                $result = array();
                for ($i = 0; $i < $numOfRecord; $i++) {
                    foreach ($pk as $col) {
                        if (empty($result[$i])) {
                            $result[$i] = array();
                        }
                        $result[$i][$col] = $rows[$col][$i];
                    }
                }
                return $result;
            }
        } else {
            // Value must always be an array
            $value = (array) $value;
        }

        if ($value) {
            // Combine the value to make a mirrored array
            $value = array_combine($value, $value);

            foreach ($value as $id) {
                // Convert the value to the proper type
                $value[$id] = parent::value($id);
            }
        }

        return $value;
    }